Skip to content

perf(#3171): cache toplevel for untracked #3185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025
Merged

perf(#3171): cache toplevel for untracked #3185

merged 1 commit into from
Aug 12, 2025

Conversation

alex-courtis
Copy link
Member

@alex-courtis alex-courtis commented Aug 11, 2025

toplevel for untracked was not cached in the getter git.get_toplevel

Only cached by one caller git.load_project, however I'm hesitant to remove it from this complex module, and it does no harm.

@alex-courtis
Copy link
Member Author

@przepompownia and @henry-hsieh I'd be most grateful if you thoroughly tested this fix branch which caches git toplevel for untracked directories.

cd /path/to/nvim-tree.lua
git pull
git checkout 3171

When you're finished testing:

git checkout master

@henry-hsieh
Copy link

It fixed the issue, the untracked directory watchers did not start after opening new files.

Copy link
Collaborator

@przepompownia przepompownia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me (#3171 (comment)).

@alex-courtis
Copy link
Member Author

Cheers @henry-hsieh @przepompownia

@alex-courtis alex-courtis merged commit 4425136 into master Aug 12, 2025
5 checks passed
@alex-courtis alex-courtis deleted the 3171 branch August 12, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants