-
Notifications
You must be signed in to change notification settings - Fork 275
feat(pick): make key query process respect the 'iminsert' option #2026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
echasnovski
merged 13 commits into
nvim-mini:backlog
from
yehorb:feature/mini-pick/respect-iminsert
Oct 20, 2025
Merged
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e9d81c4
feat(pick): add an H.get_lmap() helper that returns language map with…
yehorb e7e76fb
feat(pick): check if keymap is set before computing lmap
yehorb b256cf3
feat(pick): modify getcharstr to always try to use lmap first
yehorb 02b8b64
feat(pick): cache and use lmap when advancing picker
yehorb 83f9fe0
fix(pick): use empty lmap when invoking getcharstr for register name
yehorb 216e818
refactor(pick): remove 'keymap' check in get_lmap
yehorb 80b1af0
refactor(pick): extract charater check to a function
yehorb 2013d1c
fix(pick): check if lmap mappings are proper single characters
yehorb 0b454f3
test(pick): add simple iminsert test
yehorb 339ab10
refactor(pick): rename and improve is_single_character
yehorb 7a9963e
refactor(pick): remove warning, remove lhs check, improve rhs check
yehorb 97cef29
test(pick): add nontrivial rhs test
yehorb 2a69182
test(pick): add nontrivial lhs test
yehorb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not check 'keymap' option because language mappings can be present even if 'keymap' is not used.