Skip to content

Fix language reporting dialects as not supported #19116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 5, 2025
+5 −0
Merged

Fix language reporting dialects as not supported #19116

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
636478f
Fix unexpected changes for navigator object and wrong updates in brai…
nvdaes Oct 15, 2025
1d6ebcd
Update changelog
nvdaes Oct 15, 2025
63479ac
Fix issue number in changelog
nvdaes Oct 15, 2025
31c1dc6
Fix language reporting as not supported
nvdaes Oct 16, 2025
5286be7
Reset Outlook file
nvdaes Oct 17, 2025
9b07e4c
Merge remote-tracking branch 'origin/master' into fixLanguageReporting
nvdaes Oct 17, 2025
48d0cef
Update changelog
nvdaes Oct 17, 2025
af7c936
Merge remote-tracking branch 'origin/master' into fixLanguageReporting
nvdaes Oct 23, 2025
9002ccd
Merge remote-tracking branch 'origin/master' into fixLanguageReporting
nvdaes Nov 3, 2025
3916128
Update miscDeps
nvdaes Nov 3, 2025
aa5050f
Apply suggestions from code review
nvdaes Nov 5, 2025
44916d7
Merge remote-tracking branch 'origin/master' into fixLanguageReporting
nvdaes Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions source/synthDriverHandler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,10 @@ def languageIsSupported(self, lang: str | None) -> bool:
or lang == languageHandler.normalizeLanguage(availableLang).split("_")[0]
):
return True
rootLang = languageHandler.normalizeLanguage(lang).split("_")[0]
fallbackLang = f"{rootLang}-{rootLang}"
if fallbackLang in self.availableLanguages:
return True
return False

def initSettings(self):
Expand Down
1 change: 1 addition & 0 deletions user_docs/en/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ We recommend using Windows 11, or if that is not possible, the latest Windows 10
* When NVDA is configured to update add-ons automatically in the background, add-ons can be properly updated. (#18965, @nvdaes)
* Fixed a case where braille output would fail with an error. (#19025, @LeonarddeR)
* Battery time announcements now skip redundant "0 hours" and "0 minutes" and use proper singular/plural forms. (#9003, @hdzrvcc0X74)
* When a syntesizer has a fallback language for the current dialect, the language of the text been read won't be reported as not supported. (#18876, @nvdaes)

### Changes for Developers

Expand Down