Skip to content

Add option to mute Remote Access when not controlling the remote computer #18630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

SaschaCowley
Copy link
Member

Link to issue number:

Closes #18104

Summary of the issue:

It is often disruptive to hear what is happening on the remote computer when controling the local computer. As such, users want the ability to automatically mute output from the remote computer when controling the local computer.

Description of user facing changes:

Added an option to mute the remote computer when controlling the local computer. If enabled:

  • Mutes the remote computer when first connecting as leader;
  • Automatically mutes the remote computer when switching from remote to local control.
    This option is disabled by default.

Description of developer facing changes:

None

Description of development approach:

  • Refactored _remoteClient.client.RemoteClient.toggleMute to rely on an internal use only method that only toggles the mute state, without performing error checks or producing user output.
  • When connecting as leader, toggle to muted using the internal method if we should mute when controling the local machine.
  • Use the public method to toggle mute when switching from remote to local control (done so there is clear output, just as is done when switching the other way).
  • Added a config item to the config spec that mediates this behaviour.. Also added to the Remote Access settings panel.

Testing strategy:

Connected and disconnected as leader with this setting enabled and disabled and ensured it behaved as expected.

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to automatically mute Remote Access when controlling the local computer
1 participant