Fix unescaped "<" in MathML in PDF #18520
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce`. It isn't used in speech (although maybe it should trigger a pause if wide), but it is used in some braille notations as a signal that this is a "fill in the blank" space. I also added the elementary math attributes used in MathPlayer. Neither MathCAT nor Access8Math currently support the elementary math notations, but it is on the list of things to implement for MathCAT. Note: potentially this could go into the beta, but I can't get the beta to build on my machine so I can't test the fix there.
|
This seems to have code changes from #18508 Could you clarify if that PR should be closed in favour of this one? There will be merge conflicts when we squash merge these. |
seanbudd
changed the title
seanbudd
added
the
conceptApproved
|
My apologies. I think I forgot to checkout master before creating the new branch. They are separate bugs, but both deal with PDF math and are in proximity to each other. Hence, they are slightly related. Please do whatever is simplest. |
seanbudd
reviewed
Jul 23, 2025
Comment on lines
+16
to
18
| * Fixed '<' not being escaped in MathML in PDF documents. Most likely this will happen in `mo` elements. | ||
| * Fixed missing MathML attributes for `mspace` in PDF documents. Also passed along attributes for elementary math elements. | ||
| * Fixed support for paragraph mouse text unit in Java applications. (#18231, @hwf1324) |
There was a problem hiding this comment.
please add issue/PR numbers and attribution if you wish. Also put new sentences on new lines
|
@NSoiffer - it would probably be better to remove the duplication to make it easier to track and revert the separate changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #18511
Summary of the issue:
If the structure tree is used for MathML in PDF, calls to getValue return the interpreted
>so that it becomes<and we have an HTML syntax error.Description of user facing changes:
The bug is fixed.
Description of developer facing changes:
None.
Description of development approach:
Called
html.escape()for the result of thegetValue(when it was not "none")Testing strategy:
I used the pdf doc that was part of the issue and tested to make sure I saw the error before the fix and that there was no error after the fix.b
Known issues with pull request:
Code Review Checklist:
@coderabbitai summary