[Draft] Integrate the MathCAT add-on into NVDA #18323
Draft
+1,944
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I think we discussed this, but if it does replace MathPlayer, can that be documented in the user guide or the math presentation section be rewritten to use MathCAT content? Thanks.
|
See test results for failed build of commit 28d9c66976 |
…to mathcat-integration Merging
…to mathcat-integration Merging
See test results for failed build of commit 4298ae7b2f |
See test results for failed build of commit 7445b8eba5 |
See test results for failed build of commit 9427fd7aa8 |
See test results for failed build of commit 4ba7a139a0 |
seanbudd
changed the title
See test results for failed build of commit 4e97fcc661 |
RyanMcCleary
changed the title
…to mathcat-integration Merging
…to mathcat-integration Merging
seanbudd
reviewed
Aug 1, 2025
source/synthDrivers/espeak.py
Outdated
Comment on lines
341
to
345
| elif isinstance(item, RateCommand): | ||
| if item.multiplier == 1: | ||
| textList.append("<prosody/>") | ||
| else: | ||
| textList.append(f"<prosody rate={int(item.multiplier * 100)}%>") |
There was a problem hiding this comment.
can you see if this hack is still needed?
@NSoiffer - do you have any insights on this?
RateCommand shoukd be supported below in a similar manner in type(item) in self.PROSODY_ATTRS.
The only difference is adding textList.append("<prosody/>") whenever item.multiplier == 1.
I think we should fix up / integrate the fix into the below code if it's necessary, rather than just for the ratecommand separately
seanbudd
pushed a commit
that referenced
this pull request
Aug 5, 2025
This PR adds MathCAT assets under include/nvda-mathcat as a submodule. We are opening this as a separate PR to create this submodule before the main PR (#18323) is merged for the MathCAT integration project so that we will have access to this submodule for testing the GitHub Actions workflow in [the nvda-mathcat repo](https://github.com/nvaccess/nvda-mathcat) that automatically fetches assets from the latest MathCAT release.
seanbudd
reviewed
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #17667.
Summary of the issue:
The MathCAT add-on is not currently included in the core of NVDA. Integrating MathCAT into NVDA will give users access to mathematical content out of the box.
Description of user facing changes:
The core functionality of the add-on will remain the same, but MathCAT will be included without needing to install it as an add-on (replacing mathPlayer). An additional panel will be added in the NVDA preferences dialog containing the configuration that is currently handled in MathCAT's add-on configuration dialog. Additionally, the user docs will be updated to reflect the replacement of mathPlayer with MathCAT.
Description of developer facing changes:
The code from the MathCAT add-on has been refactored and cleaned up to conform to NVDA's coding standards, and that code is included in the
mathPres/MathCATdirectory with this PR. Dependencies have been added as a Git submodule ininclude/nvda-mathcat. Before this PR is ready for review, changes will also be made to the way MathCAT is initialized (currently, it is only set up to be loaded as an add-on), and YAML configuration will be replaced with configobj.Description of development approach:
Developments will proceed in the following steps:
Testing strategy:
The add-on code after refactoring has been tested only by loading it into NVDA and testing it functionally. Discussion of more unit and system tests is ongoing.
Known issues with pull request:
libmathcat_py.pydwas included in that MathCAT directory. Now, it is located ininclude/assets, so it is not being imported correctly. This can be fixed by updatingpyproject.tomlwith the new path.Code Review Checklist:
@coderabbitai summary