Skip to content

fix(Input/Textarea): define model modifiers types #4195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 22, 2025
Merged

fix(Input/Textarea): define model modifiers types #4195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6d37d8e
fix(Input/Textarea): v-model modifiers produce type errors
HugoRCD May 20, 2025
944e06c
up
HugoRCD May 20, 2025
ab54c61
up
HugoRCD May 20, 2025
6be6b2b
up
HugoRCD May 20, 2025
0300319
up
benjamincanac May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/runtime/components/Input.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,13 @@ export interface InputProps extends UseComponentIconsProps {
disabled?: boolean
/** Highlight the ring color like a focus state. */
highlight?: boolean
modelModifiers?: {
string?: boolean
number?: boolean
trim?: boolean
lazy?: boolean
nullify?: boolean
}
class?: any
ui?: Input['slots']
}
Expand Down Expand Up @@ -77,6 +84,7 @@ const props = withDefaults(defineProps<InputProps>(), {
const emits = defineEmits<InputEmits<T>>()
const slots = defineSlots<InputSlots>()

// eslint-disable-next-line vue/no-dupe-keys
const [modelValue, modelModifiers] = defineModel<T>()

const appConfig = useAppConfig() as Input['AppConfig']
Expand Down
9 changes: 8 additions & 1 deletion src/runtime/components/Textarea.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,17 @@ export interface TextareaProps extends UseComponentIconsProps {
autoresize?: boolean
autoresizeDelay?: number
disabled?: boolean
class?: any
rows?: number
maxrows?: number
/** Highlight the ring color like a focus state. */
highlight?: boolean
modelModifiers?: {
string?: boolean
trim?: boolean
lazy?: boolean
nullify?: boolean
}
class?: any
ui?: Textarea['slots']
}

Expand Down Expand Up @@ -76,6 +82,7 @@ const props = withDefaults(defineProps<TextareaProps>(), {
const emits = defineEmits<TextareaEmits<T>>()
const slots = defineSlots<TextareaSlots>()

// eslint-disable-next-line vue/no-dupe-keys
const [modelValue, modelModifiers] = defineModel<T>()

const appConfig = useAppConfig() as Textarea['AppConfig']
Expand Down