fix(Select): support more primitive types in value field

[Norbiros]

🔗 Linked issue

❓ Type of change

• 📖 Documentation (updates to the documentation or readme)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality)
• ✨ New feature (a non-breaking change that adds functionality)
• 🧹 Chore (updates to the build process or auxiliary tools and libraries)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We were trying to create USelect for bool type and it haven't worked. I allowed all other primitive types that are intented to be used here (no array, objects etc).

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[pkg-pr-new]

npm i https://pkg.pr.new/@nuxt/ui@4105

commit: 4685f6e

[sandros94]

Indeed interesting, as upstream they have typed to accept only type AcceptableValue = string | number | Record<string, any> | null.

I think the addition of new types should be done upstream and not here. Tho the typing for USelect's value needs to be fixed

[Norbiros]

Interestingly, it doesn't produce any type errors... They explicitly removed boolean from the AcceptableValue in unovue/reka-ui@b567c7a. So maybe for now I could leave here AcceptableValue | boolean, open PR in reka with bigint | symbol and open an issue about using bool in Select?

[sandros94]

Interestingly, it doesn't produce any type errors... They explicitly removed boolean from the AcceptableValue in unovue/reka-ui@b567c7a. So maybe for now I could leave here AcceptableValue | boolean, open PR in reka with bigint | symbol and open an issue about using bool in Select?

It doesn't create any error because SelectItemBase is the base type for the items prop. In Reka's term we are using Record<string, any>, so I totally agree to make it value?: AcceptableValue | boolean.

For the other types indeed, should be implemented upstream (hoping there aren't any issue with those, tho symbol might have).

[benjamincanac]

@sandros94 Shouldn't we juste remove the value field like you did on InputMenu and SelectMenu? 🤔

[sandros94]

@sandros94 Shouldn't we juste remove the value field like you did on InputMenu and SelectMenu? 🤔

no because we currently have valueKey defaulting to value, while for SelectMenu and InputMenu we don't.

ui/src/runtime/components/Select.vue

Line 153 in 46c2987

valueKey: 'value' as never,

We could remove both to make Select follow the same api from the other two tho, but I might be missing an issue I've found in the past which led me leave it when I was doing the type rewrite 🤔

[Norbiros]

Do I have to do something more or this can get merged?