Skip to content

Conversation

@hanneskuettner
Copy link
Contributor

πŸ”— Linked issue

#3920

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Let's try this again. As #3922 (comment) points out the previous PR fell victim to the large merges that happened in the neutral utility PR.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@benjamincanac
Copy link
Member

Damn, sorry about that. I might have messed up somewhere 😬

@hanneskuettner
Copy link
Contributor Author

hanneskuettner commented Apr 28, 2025

Damn, sorry about that. I might have messed up somewhere 😬

No worries! That truly was a mean PR to keep updated with main πŸ˜…

@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 28, 2025

npm i https://pkg.pr.new/@nuxt/ui@4010

commit: 6b0d529

@benjamincanac benjamincanac merged commit 0f2d2e5 into nuxt:v3 Apr 28, 2025
5 checks passed
@benjamincanac
Copy link
Member

Are you sure this is really a good idea? πŸ€” Should not happen for this case:
CleanShot 2025-04-29 at 10 19 24@2x
https://ui.nuxt.com/components/select-menu#with-filter-fields

@hanneskuettner
Copy link
Contributor Author

hanneskuettner commented Apr 29, 2025

Are you sure this is really a good idea? πŸ€” Should not happen for this case:

Hmm I agree that this is not really desired for the case you are showing... On the other hand, I seems super desired for that the trigger does not have an explicit width set, like in the original issue. πŸ€”

I'm also happy if we revert this, because arguably your example is a lot worse than the original issue, IMO and the user can deal with this on a case by case basis.

Or we can make it a prop on the component if it is something we want to support natively. Not sure what the best way is and I will defer to you entirely there.

benjamincanac added a commit that referenced this pull request Apr 29, 2025
Copy link
Member

I've reverted it, it's easy enough to do :ui="{ content: 'min-w-fit' }" I guess.

@benjamincanac benjamincanac added the v3 #1289 label May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v3 #1289

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants