Skip to content

fix: eagerly initialise dependencies cache #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2023
Merged

fix: eagerly initialise dependencies cache #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export function getModuleDependencies (id: string, rendererContext: RendererCont
return rendererContext._dependencies[id]
}

const dependencies: ModuleDependencies = {
const dependencies: ModuleDependencies = rendererContext._dependencies[id] = {
scripts: {},
styles: {},
preload: {},
Expand All @@ -89,7 +89,6 @@ export function getModuleDependencies (id: string, rendererContext: RendererCont
const meta = rendererContext.manifest[id]

if (!meta) {
rendererContext._dependencies[id] = dependencies
return dependencies
}

Expand Down Expand Up @@ -122,7 +121,6 @@ export function getModuleDependencies (id: string, rendererContext: RendererCont
}
dependencies.preload = filteredPreload

rendererContext._dependencies[id] = dependencies
return dependencies
}

Expand Down Expand Up @@ -255,7 +253,7 @@ export function createRenderer (createApp: any, renderOptions: RenderOptions & {
const app = await _createApp(ssrContext)
const html = await renderOptions.renderToString(app, ssrContext)

const wrap = <T extends RenderFunction>(fn: T) => () => fn(ssrContext, rendererContext) as ReturnType<T>
const wrap = <T extends RenderFunction> (fn: T) => () => fn(ssrContext, rendererContext) as ReturnType<T>

return {
html,
Expand Down