Skip to content

Conversation

SwayamInSync
Copy link
Member

Continuing #130

@SwayamInSync
Copy link
Member Author

@ngoldbaum continuing from #134

@ngoldbaum
Copy link
Member

I think it should be possible to build the sdist without compiling sleef or the dtype but that seems to be how it's wired up now, so this is probably fine. There's probably a way to set up the meson config to fix that. But also I doubt anyone will care because the sdist is getting generated by a CI job.

Anyway, all that to say, looks good! Please go ahead and tag a release :)

@ngoldbaum ngoldbaum merged commit 86992bf into numpy:main Aug 27, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Numpy-QuadDType v1.0 roadmap Aug 27, 2025
@ngoldbaum ngoldbaum mentioned this pull request Aug 27, 2025
@SwayamInSync
Copy link
Member Author

I think it should be possible to build the sdist without compiling sleef or the dtype but that seems to be how it's wired up now, so this is probably fine. There's probably a way to set up the meson config to fix that. But also I doubt anyone will care because the sdist is getting generated by a CI job.

Anyway, all that to say, looks good! Please go ahead and tag a release :)

Yes I tried doing without SLEEF and got the following meson error

../meson.build:17:4: ERROR: C shared or static library 'sleef' not found

will check out if it's possible via some config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants