ENH: Add usage of new sorting dtype slots #109
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR depends on numpy/numpy#28516 and will break without it.
This is to start writing some examples for the new sorting slots in numpy/numpy#28516. Currently, just a patch to use the new
sort_compareslot for mpfdtype: this is the only place I found sorting-related features to be implemented already but there's probably ways we can optimize it further for the various dtypes.I realize this is a bit spares right now, mainly because I wonder if any further optimizations are called for in
get_sort_functionitself. One could reimplement quicksort, for example, and I can see a case for things like bucketing by sign or exponent. Not sure if that would be too complex for now. But if we don't, we don't have an example for most of the slots...