-
Notifications
You must be signed in to change notification settings - Fork 445
Use hatch as build system instead of setuptools #848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
willingc
wants to merge
32
commits into
nteract:main
Choose a base branch
from
willingc:test-hatch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
38a2971
Convert setup.py using hatch
willingc 293f576
move tools into pyproject.toml
willingc 3fd9cb5
comment out setup.py
willingc c8df7d9
add hatch-vcs and troubleshoot version
willingc 922ce2e
update version handling
willingc 2fbdd85
add dynamic versioning files for git
willingc ec0bc27
remove setup.py
willingc fa5f140
update manifest
willingc 75bf9da
remove setuptools from files and add doc note
willingc 3328e16
fix if in ci action
willingc e252211
update license and classifier
willingc 9b151ac
update url for markdown precommit
willingc 1123c19
update url for black precommit
willingc e14e1d0
move pytest.ini to pyproject.toml
willingc bb39832
apply scientific python recommendations for pytest config
willingc 10dd869
remove unneeded ruff python version
willingc bbccc49
use spdx license specifier
willingc b81ccb9
update pytest filter warning
willingc 4e9cad0
remove unneeded requirements file
willingc e163fb5
add hatch to dev dependencies
willingc 17ae1d5
dedupe dependencies
willingc 7c69ce5
Remove requirements files
willingc 35e5a7a
remove manifest and check-manifest
willingc 45f3904
Remove unneeded doc note
willingc 9230e54
remove manifest from pyproject
willingc 7d0fcda
add azure to docs for tox
willingc 025ae5c
Update binder tox config
willingc 205e9c9
Update pyproject.toml all deps
willingc 3c36817
Update pyproject.toml to order classifiers
willingc 584680a
Update pyproject.toml with style for spacing
willingc 710cccf
Update pyproject.toml ignore-vcs for sdist
willingc 73aaa13
Update pyproject.toml embedded quotes
willingc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| node: $Format:%H$ | ||
| node-date: $Format:%cI$ | ||
| describe-name: $Format:%(describe:tags=true,match=*[0-9]*)$ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| papermill/_version.py export-subst | ||
| .git_archival.txt export-subst | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -29,13 +29,13 @@ jobs: | |||||
| set -xe | ||||||
| python -VV | ||||||
| python -m site | ||||||
| python -m pip install --upgrade pip setuptools wheel coverage[toml] virtualenv tox tox-gh-actions | ||||||
| python -m pip install --upgrade pip wheel coverage[toml] virtualenv tox tox-gh-actions | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure what CI is doing but I think this would also be unnecessary now:
Suggested change
|
||||||
|
|
||||||
| - name: "Run tox targets for ${{ matrix.python-version }}" | ||||||
| run: python -m tox | ||||||
|
|
||||||
| - name: "Generate coverage XML" | ||||||
| if: "contains(env.USING_COVERAGE, matrix.python-version)" | ||||||
| if: contains(env.USING_COVERAGE, matrix.python-version) | ||||||
| run: python -m coverage xml | ||||||
|
|
||||||
| - name: "Upload coverage to Codecov" | ||||||
|
|
@@ -46,7 +46,7 @@ jobs: | |||||
| strategy: | ||||||
| fail-fast: false | ||||||
| matrix: | ||||||
| toxenv: ["manifest", "docs", "binder"] | ||||||
| toxenv: ["docs", "binder"] | ||||||
| env: | ||||||
| TOXENV: ${{ matrix.toxenv }} | ||||||
| steps: | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh one more thing, is this accurate?