Implemented Arg.Is matcher and generic constraints #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtchepak
approved these changes
Sep 3, 2023
| /// If the generic type parameter has constraints, you will have to create a derived class/struct that | ||
| /// implements those constraints. | ||
| /// </remarks> | ||
| public interface AnyType |
There was a problem hiding this comment.
thought: what do you think about providing implementations for common constraints? In particular AnyClass (with default ctor to match : class, new()), and AnyStruct or AnyValueType.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a part of #634.
Arg.AnyTypedoes not work when the type we replace has generic constraints. Therefore we convertedAnyTypeto an interface so that the user can implement a custom class that satisfies the constraints.Arg.Ismatcher was not supported by the former PR (#715).XML-Doc comments have been added to
Arg.AnyType.