CastleDynamicProxyFactory_HasItem_true_when_array_is_null #683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appel1
reviewed
Mar 3, 2022
src/NSubstitute/Proxies/CastleDynamicProxy/CastleDynamicProxyFactory.cs
Outdated
Show resolved
Hide resolved
phongphanq
force-pushed
the
CastleDynamicProxyFactory_HasItem_true_when_array_is_null
branch
from
e142dd4 to
7ff4994
Compare
Mandroide
approved these changes
Apr 17, 2022
|
Can someone merge this please? |
|
Thanks for this! 🙇 |
|
Thank you @dtchepak. When can I expect this to hit a nuget release? |
|
@rcdailey Just published 4.4.0. Could you please confirm this issue is resolved? |
|
@dtchepak Sorry for the delay. I responded in another issue, but I'm not able to reproduce the issue anymore after upgrading to v4.4.0. Thank you for the fix!! |
rcdailey
added a commit
to recyclarr/recyclarr
that referenced
this pull request
Aug 23, 2022
Fixes these issues that were introduced after v4.2.2: - nsubstitute/NSubstitute#683 - nsubstitute/NSubstitute#685 - MRCollective/AutofacContrib.NSubstitute#65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method HasItem used to check the constructorArguments is incorrect when passing null object.