Skip to content

Conversation

@ploxiln
Copy link
Member

@ploxiln ploxiln commented Sep 12, 2021

follow-up to #33

@ploxiln ploxiln requested a review from mreiferson September 12, 2021 21:08
Copy link
Member

@mreiferson mreiferson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

debian-based images have gcc (needed for -race) and git
(possible with alpine image but would need more install steps)

go test -race is not supported on 386

Also, go test without -v, but list tests first:
go-diskqueue tests produce a lot of distracting error logging output,
and if a test fails, a pretty good amount of logging context is provided.
switch Travic-CI badge to a GitHub Actions badge

update GoDoc badge to pkg.go.dev "Go Reference" badge
(it was already being redirecting to the new site)
@ploxiln ploxiln force-pushed the github_actions_fixup branch from 648382e to 31c9997 Compare September 12, 2021 21:36
@ploxiln ploxiln merged commit bc05aaf into nsqio:master Sep 12, 2021
@ploxiln ploxiln deleted the github_actions_fixup branch September 12, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants