Skip to content

Inaccurate depth count after readError on "current" file #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2021
Merged

Inaccurate depth count after readError on "current" file #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03359f6
Ensure that depth is 0 if readFileNum == writeFileNum and readPos == …
kev1n80 Jul 6, 2021
f2ecc37
Add test for tail corruption when last file is corrupted.
kev1n80 Sep 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions diskqueue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,6 +608,8 @@ func (d *diskQueue) handleReadError() {

// significant state change, schedule a sync on the next iteration
d.needSync = true

d.checkTailCorruption(d.depth)
}

// ioLoop provides the backend for exposing a go channel (via ReadChan())
Expand Down
17 changes: 17 additions & 0 deletions diskqueue_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,23 @@ func TestDiskQueueCorruption(t *testing.T) {
dq.Put(msg)

Equal(t, msg, <-dq.ReadChan())

dq.Put(msg)
dq.Put(msg)
// corrupt the last file
dqFn = dq.(*diskQueue).fileName(5)
os.Truncate(dqFn, 100)

Equal(t, int64(2), dq.Depth())

// return one message and try reading again from corrupted file
<-dq.ReadChan()

// give diskqueue time to handle read error
time.Sleep(50 * time.Millisecond)

// the last log file is now considered corrupted leaving no more log messages
Equal(t, int64(0), dq.Depth())
}

type md struct {
Expand Down