Upgrade NeoGo #3040
Merged
Upgrade NeoGo #3040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
requested review from
carpawell and
cthulhu-rider
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3040 +/- ##
==========================================
- Coverage 22.63% 22.42% -0.21%
==========================================
Files 791 791
Lines 58616 58405 -211
==========================================
- Hits 13265 13095 -170
+ Misses 44453 44415 -38
+ Partials 898 895 -3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Roman Khimov <[email protected]>
Member
Author
|
Blocked by nspcc-dev/neofs-testcases#903. |
Member
Author
|
It's fixed already, but for whatever reason GH can't process the branch update (see above). |
And drop all related logic for checking the type of event. We never care about removed requests. Fixes #2672. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
up-neo-go
branch
from
9dbce2d to
8555eef
Compare
roman-khimov
force-pushed
the
up-neo-go
branch
from
8555eef to
b9b5146
Compare
The latest fixes. Signed-off-by: Roman Khimov <[email protected]>
| ch := make(chan *result.NotaryRequestEvent) | ||
| var ( | ||
| ch = make(chan *result.NotaryRequestEvent) | ||
| evtype = mempoolevent.TransactionAdded |
Contributor
There was a problem hiding this comment.
4 green lines instead of 1 🫥
cthulhu-rider
approved these changes
Dec 9, 2024
carpawell
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.