object/acl: check session token verb #1203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1203 +/- ##
==========================================
+ Coverage 35.64% 35.68% +0.03%
==========================================
Files 288 288
Lines 18131 18144 +13
==========================================
+ Hits 6463 6474 +11
- Misses 11177 11179 +2
Partials 491 491
Continue to review full report at Codecov.
|
alexvanin
suggested changes
Mar 4, 2022
pkg/services/object/acl/acl.go
Outdated
| // Check if session token verb is equal to the current operation. | ||
| // Unknown means everything is allowed. | ||
| verb := sourceVerbOfRequest(req.token, op) | ||
| if verb != op { |
Contributor
There was a problem hiding this comment.
Unfortunately, we can't simply compare op and value from token. One request type can produce requests of other type. During the tests, I logged such errors:
token: DELETE op: PUT
token: DELETE op: HEAD
token: GETRANGEHASH op: GETRANGE
We also have this table in spec of produced request types.
| Base/Gen | PUT | DELETE | HEAD | RANGE | GET | HASH | SEARCH |
|---|---|---|---|---|---|---|---|
| PUT | + | - | - | - | - | - | - |
| DELETE | + | - | + | - | - | - | + |
| HEAD | - | - | + | - | - | - | - |
| RANGE | - | - | + | + | - | - | - |
| GET | - | - | + | - | + | - | - |
| HASH | - | - | + | + | - | - | - |
| SEARCH | - | - | - | - | - | - | + |
alexvanin
reviewed
Mar 4, 2022
pkg/services/object/acl/acl.go
Outdated
| // find verb from token if it is present | ||
| verb := sourceVerbOfRequest(req, op) | ||
| // Check if session token verb is equal to the current operation. | ||
| // Unknown means everything is allowed. |
Contributor
There was a problem hiding this comment.
Also, can you fix API spec and mention such behavior there?
Signed-off-by: Evgenii Stratonikov <[email protected]>
alexvanin
approved these changes
Mar 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1191 .
Signed-off-by: Evgenii Stratonikov [email protected]