Fix maxDomainNameFragmentLength #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterSplinter01
pushed a commit
to masterSplinter01/neofs-contract
that referenced
this pull request
Apr 4, 2022
Signed-off-by: Angira Kekteeva <[email protected]>
masterSplinter01
force-pushed
the
fix-domain-fragment-length
branch
from
d2adf08 to
085ca06
Compare
|
Could you add |
fyrchik
approved these changes
Apr 5, 2022
maxDomainNameFragmentLength means maximum length of label of domain name A label may contain zero to 63 characters. The null label, of length zero, is reserved for the root zone. The full domain name may not exceed the length of 253 characters in its textual representation Signed-off-by: Angira Kekteeva <[email protected]>
masterSplinter01
force-pushed
the
fix-domain-fragment-length
branch
from
085ca06 to
e2e1a47
Compare
alexvanin
approved these changes
Apr 5, 2022
AnnaShaleva
added a commit
to AnnaShaleva/non-native-contracts
that referenced
this pull request
Sep 5, 2022
According to [RFC 1034](https://datatracker.ietf.org/doc/html/rfc1034#section-3.1), "Each node has a label, which is zero to 63 octets in length". Originally fixed in nspcc-dev/neofs-contract#238.
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Sep 5, 2022
AnnaShaleva
added a commit
to AnnaShaleva/non-native-contracts
that referenced
this pull request
Sep 6, 2022
According to [RFC 1034](https://datatracker.ietf.org/doc/html/rfc1034#section-3.1), "Each node has a label, which is zero to 63 octets in length". Originally fixed in nspcc-dev/neofs-contract#238.
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Sep 8, 2022
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I understand correctly,
maxDomainNameFragmentLengthmeans maximum length of label of domain name.By wiki and spec:
But now we compare with 62 and don't allow labels with 63 octets length.