object/replicate: Add signature to the replication RPC #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carpawell
force-pushed
the
feat/add-replication-signing
branch
from
7f0744e to
5d167b1
Compare
to me it's unclear too. Lucky we can freely change it later. Now i cannot suggest nothing better than straightforward |
cthulhu-rider
previously approved these changes
Jul 5, 2024
roman-khimov
previously approved these changes
Jul 17, 2024
carpawell
dismissed stale reviews from roman-khimov and cthulhu-rider
via
a5de2ef
carpawell
force-pushed
the
feat/add-replication-signing
branch
from
5d167b1 to
a5de2ef
Compare
|
@cthulhu-rider, @roman-khimov, renamed the field name and specified signature algorithm. Do you have any preferences about the scheme? Do we have any rules of when we try to use one or another? |
cthulhu-rider
previously approved these changes
Jul 26, 2024
Object signing now may be requested to ensure a replication copy was received. Closes #299. Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
feat/add-replication-signing
branch
from
a5de2ef to
0ae1cc7
Compare
cthulhu-rider
approved these changes
Jul 26, 2024
|
@roman-khimov, have you something to add here? |
|
I'm mostly concerned about ersatz-chain test results. |
roman-khimov
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure about
createnaming.