*: move Notary contract out of P2PSigExtensions under Echidna hardfork

[AnnaShaleva]

Close #3464.

[codecov]

Codecov Report

Attention: Patch coverage is 64.86486% with 13 lines in your changes missing coverage. Please review.

Project coverage is 82.62%. Comparing base (9e8100a) to head (48f90d7).
Report is 7 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/core/blockchain.go	14.28%	4 Missing and 2 partials ⚠️
pkg/core/native/notary.go	50.00%	3 Missing and 2 partials ⚠️
pkg/core/statesync/module.go	80.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3478      +/-   ##
==========================================
- Coverage   82.64%   82.62%   -0.03%     
==========================================
  Files         342      342              
  Lines       48277    48289      +12     
==========================================
- Hits        39899    39897       -2     
- Misses       6727     6748      +21     
+ Partials     1651     1644       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[AnnaShaleva]

Moved Notary functionality from Domovoi under Echidna hardfork.

[AnnaShaleva]

Oh-oh, probably need to move it under next hardfork. Ref. #3554 and neo-project/neo#3454.

[roman-khimov]

It still can be a part of Echidna. But for now we don't need to change anything anyway, it's totally C#-dependent.

[AnnaShaleva]

@roman-khimov, I can't request review from copilot, do I need some extra rights for that?

[roman-khimov]

I think it needs to be enabled for your account (check GH settings)

[Copilot]

Pull Request Overview

This pull request decouples the Notary contract deployment from the P2PSigExtensions flag and instead gates its activation through hardfork configurations (including Echidna and Domovoi). Key changes include:

• Removing the conditional block based on P2PSigExtensions in contract creation.
• Updating numerous tests to eliminate dependencies on P2PSigExtensions and to use hardfork-defined activation.
• Adjusting configuration and documentation to reflect the new activation thresholds for native contracts.

Reviewed Changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
pkg/core/native/native_test/neo_test.go	Configured hardfork mapping for Notary contract activation in tests.
pkg/core/native/native_test/management_test.go	Updated expected events and removed P2PSigExtensions-related settings.
pkg/core/native/gas_test.go	Removed forced P2PSigExtensions enabling in custom config for GAS tests.
pkg/core/native/contract.go	Removed the condition to add the Notary contract only if P2PSigExtensions is set.
config/protocol.unit_testnet.yml	Updated hardfork activation heights to reflect new protocol upgrade logic.
docs/node-configuration.md	Adjusted Notary documentation to remove reference to P2PSigExtensions.
[other test and internal files]	Similar removals of P2PSigExtensions settings to be replaced by hardfork checks.

Comments suppressed due to low confidence (4)

pkg/core/native/contract.go:101

• The removal of the cfg.P2PSigExtensions conditional means the Notary contract is now always deployed. Verify that downstream modules and tests relying on conditional deployment are updated to use hardfork configuration exclusively.

if cfg.P2PSigExtensions {

pkg/core/native/native_test/management_test.go:49

• The tests have been updated to remove P2PSigExtensions enabling and instead rely on hardfork mappings for Notary activation. Ensure all test scenarios covering Notary deployment via hardfork configuration are adequately exercised.

cfg.P2PSigExtensions = true

config/protocol.unit_testnet.yml:20

• The hardfork activation heights have been updated. Confirm that these new values are consistent with the intended network upgrade schedule and documented across all relevant channels.

Aspidochelone: 1, Basilisk: 2, Cockatrice: 3, Domovoi: 4, Echidna: 5

docs/node-configuration.md:417

• The Notary contract deployment no longer relies on the P2PSigExtensions flag; update the documentation to reflect that its activation is now governed by hardfork configuration.

| P2PSigExtensions | `bool` | `false` | ... |

[roman-khimov]

--- FAIL: TestDBRestoreDump (0.10s)
--- PASS: TestDBRestoreDump/excessive_restore_parameters (0.00s)
panic: item with id = -10 and key = 0a is not initialized [recovered]
panic: item with id = -10 and key = 0a is not initialized

[AnnaShaleva]

--- FAIL: TestDBRestoreDump (0.10s)
--- PASS: TestDBRestoreDump/excessive_restore_parameters (0.00s)
panic: item with id = -10 and key = 0a is not initialized [recovered]
panic: item with id = -10 and key = 0a is not initialized

It's due to #3478 (comment). Unexpected. I reverted it and renamed activeIn to notaryActiveIn, let it be the global variable.