Remove table output #7401
Merged
Remove table output #7401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only need it for `scripts/publish.js`
Member
Author
|
Done |
wraithgar
force-pushed
the
gar/no-tables
branch
from
e289c34 to
ce7b3da
Compare
This removes table output from `hook`, `profile`, `doctor`, `org`, and `token`. It also removes table output from the `--long` or `--dry-run` output of install commands. Table output is discouraged in a cli for accessibility reasons. The tests for `token` were also rewritten because they did not actually test the behavior of npm with the registry. `this.config` was also removed from `token`. npm-registry-fetch pulls all this from flatOptions already.
wraithgar
force-pushed
the
gar/no-tables
branch
from
ce7b3da to
3b0e76e
Compare
lukekarrys
reviewed
Apr 22, 2024
lukekarrys
reviewed
Apr 22, 2024
lukekarrys
approved these changes
Apr 22, 2024
Merged
This was referenced Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes almost all table output from npm. Table output is
discouraged for clis because it is not very accessible.
npm outdatedstill has it, but that will likely take a little moredesign/time to iron out.
npm searchstill has it, and the summary of a tarball still has it. Those are next to be removed.There is a deps commit here moving
cli-table3todevDependenciessince we now only use it for
./scripts/publish.js