Skip to content

Fixed "publish --force" not correctly publishing for already published packages #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed "publish --force" not correctly publishing for already published packages #565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/publish.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ function upload (pkg, isRetry, cached, opts) {
)).finally(() => {
// ignore errors. Use the force. Reach out with your feelings.
return otplease(opts, opts => {
return upload(pkg, true, tarball, opts)
return upload(pkg, true, cached, opts)
Copy link
Contributor

@isaacs isaacs Jan 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be replacing upload with libpub, not replacing tarball with cached. Note that the function it's retrying is libpub, not upload?

We need a test in any event, and probably some more investigation.

}).catch(() => {
// but if it fails again, then report the first error.
throw err
Expand Down