Skip to content

fix: npm hook ls duplicates hook name prefixes #5295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 19, 2022
Merged

fix: npm hook ls duplicates hook name prefixes #5295

merged 3 commits into from
Oct 19, 2022

Conversation

@gennadiygashev
Copy link
Contributor

@gennadiygashev gennadiygashev commented Aug 10, 2022 •
edited
Loading

  • Fixes double prefix for hooks scopes names
  • Fixes libnpmhook mocks (In the function logic, the symbol @ is not removed from the hooks scopes names, but in mocks it is removed. I fixed the mocks and made this logic like in a function.)
  • Fixes wrong test cases

References

fixes #4201

@gennadiygashev gennadiygashev changed the title fix: fix: npm hook ls duplicates hook name prefixes Aug 10, 2022
@gennadiygashev gennadiygashev marked this pull request as ready for review August 10, 2022 18:05
@gennadiygashev gennadiygashev requested a review from a team as a code owner August 10, 2022 18:05
@lukekarrys lukekarrys added the Needs Triage needs review for next steps label Aug 24, 2022
@fritzy fritzy force-pushed the latest branch 2 times, most recently from 3037d35 to f3b0c43 Compare September 14, 2022 23:09
@lukekarrys lukekarrys merged commit fc82298 into npm:latest Oct 19, 2022
@github-actions github-actions bot mentioned this pull request Oct 19, 2022
Merged
lukekarrys pushed a commit that referenced this pull request Oct 19, 2022
@gennadiygashev @lukekarrys
fix: npm hook ls duplicates hook name prefixes (#5295)
6ffa5b7 
* fix: duplicate hook names

* fix: incorrect names in mocks
@lukekarrys lukekarrys mentioned this pull request Nov 1, 2022
Closed
This was referenced Nov 5, 2022
Closed
Closed
@npm-cli-bot npm-cli-bot mentioned this pull request Nov 16, 2022
Closed
@npm-cli-bot npm-cli-bot mentioned this pull request Nov 30, 2022
Merged
@jackromo888 jackromo888 mentioned this pull request Jun 27, 2023
Open
@adamlaska adamlaska mentioned this pull request Nov 28, 2023
Open
@kevinjm39 kevinjm39 mentioned this pull request Nov 30, 2023
Open
@LadyK-21 LadyK-21 mentioned this pull request Dec 1, 2023
Open
@jackromo888 jackromo888 mentioned this pull request Dec 1, 2023
Open
@adamlaska adamlaska mentioned this pull request Dec 1, 2023
Open
@kevinjm39 kevinjm39 mentioned this pull request Dec 19, 2023
Open
@Rose2161 Rose2161 mentioned this pull request Mar 14, 2024
Open
@adamlaska adamlaska mentioned this pull request Mar 15, 2024
Open
@jackromo888 jackromo888 mentioned this pull request Mar 17, 2024
Open
@Rose2161 Rose2161 mentioned this pull request Mar 22, 2024
Open
@adamlaska adamlaska mentioned this pull request Mar 22, 2024
Open
@jackromo888 jackromo888 mentioned this pull request Mar 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees

No one assigned

Labels

Needs Triage needs review for next steps

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

npm hook ls duplicates hook name prefixes

3 participants

@gennadiygashev @wraithgar @lukekarrys