Skip to content

utils: update npm.config condition check in error-handler.js #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2018
Merged

utils: update npm.config condition check in error-handler.js #108

merged 1 commit into from
Dec 10, 2018

Conversation

@BeniCheni
Copy link
Contributor

@BeniCheni BeniCheni commented Dec 5, 2018

Refs this topic on npm.community, this PR updates npm.config condition check in error-handler.js based on the suggestion from post #2.

@BeniCheni BeniCheni requested a review from a team as a code owner December 5, 2018 04:54
@zkat zkat added the semver:patch semver patch level for changes label Dec 6, 2018
zkat
zkat approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zkat zkat merged commit 90e55a1 into npm:release-next Dec 10, 2018
@BeniCheni BeniCheni deleted the error-handler-patch branch December 11, 2018 04:18
aeschright pushed a commit that referenced this pull request Jan 18, 2019
@BeniCheni @aeschright
utils: check npm.config existence in error-handler.js (#108)
49358f1 
Fixes: https://npm.community/t/npx-envinfo-preset-jest-fails-on-windows-with-a-stack-trace/2713
PR-URL: #108
Credit: @BeniCheni
Reviewed-By: @zkat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zkat zkat zkat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

semver:patch semver patch level for changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BeniCheni @zkat