Skip to content

UPNP Support - Minor fixes #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 3, 2019
Merged

UPNP Support - Minor fixes #6

merged 7 commits into from
Jul 3, 2019

Conversation

@mbaxter
Copy link

@mbaxter mbaxter commented Jul 3, 2019

PR description

Fix a few small issues:

  • DefaultP2PNetwork
    • Make sure NAT setup is handled before enode url is constructed
    • Request UDP port forwarding for discovery service
    • Add a test
  • Request port forwarding in JsonRpcHttpService after port is fully resolved
  • Fix some minor style issues in UpnpNatManager
    • Use final variables where possible
    • Use Optional over nullable values
  • Implement shutdown method in PantheonUpnpServiceConfiguration
  • Make package names consistent with directory structure
  • Remove some unnecessary dependencies

shemnon
shemnon reviewed Jul 3, 2019
View reviewed changes
ethereum/p2p/src/main/java/tech/pegasys/pantheon/ethereum/p2p/network/DefaultP2PNetwork.java
.requestPortForward(
this.config.getDiscovery().getBindPort(),
UpnpNatManager.Protocol.TCP,
UpnpNatManager.Protocol.UDP,
Copy link

@shemnon shemnon Jul 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need both TCP and UDP or is discovery UDP only?

Copy link
Author

@mbaxter mbaxter Jul 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discovery is UDP only. There's another request for rlpx TCP port below.

@mbaxter mbaxter mentioned this pull request Jul 3, 2019
Merged
@notlesh notlesh merged commit e461e69 into notlesh:upnp_support Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shemnon shemnon shemnon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mbaxter @shemnon @notlesh