Add support for <experimental/scope> header #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
striezel
force-pushed
the
support-experimental-scope-header
branch
from
8c24861 to
141d3f5
Compare
|
@martinmoene This pull request is now ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some compilers do not have the
<scope>header, but they use<experimental/scope>instead and place the types in thestd::experimentalnamespace.This pull request adds compatibility for such compilers.
Note: This is intentionally left as a draft pull request, because there is no CI job with a compiler that uses<experimantal/scope>yet. Please review #16 first. It not only fixes the existing Clang builds on GHA, it also introduces a job for Clang 19 on Ubuntu 24.04. And that compiler has the<experimantal/scope>header. After that is merged I will rebase this pull request to make sure it build and passes the tests with Clang 19.