Skip to content

perf: Remove double-stringify in setCookie #2980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2024
Merged

perf: Remove double-stringify in setCookie #2980

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ec75ec
Remove double-stringify in setCookie
peterver Mar 21, 2024
f3de914
Remove unnecessary semicolon
peterver Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/web/cookies/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ function setCookie (headers, cookie) {
const str = stringify(cookie)

if (str) {
headers.append('Set-Cookie', stringify(cookie))
headers.append('Set-Cookie', str);
}
}

Expand Down