-
-
Couldn't load subscription status.
- Fork 6.4k
chore: remove unused partner logos #8242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8242 +/- ##
==========================================
- Coverage 76.45% 76.44% -0.02%
==========================================
Files 115 115
Lines 9643 9643
Branches 317 317
==========================================
- Hits 7373 7372 -1
- Misses 2269 2270 +1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Removes unused partner logo components from the UI components package and reduces the PartnerLogos barrel to only export the logos still in use.
- Deletes directories and components for unused partner logos (e.g., ARM, Crowdin, DataDog, EquinixMetal, IBM, OpenSSF, Rackspace, Scaleway, Sentry, Vlt)
- Updates the PartnerLogos index to only import and export the remaining logos
- Streamlines the package surface area to only the currently used partner logos
Reviewed Changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/ui-components/src/Icons/PartnerLogos/index.ts | Shrinks the barrel to export only the remaining in-use logos; removes imports/exports for deleted logos |
| packages/ui-components/src/Icons/PartnerLogos/Vlt/* | Removes Vlt logo components and index |
| packages/ui-components/src/Icons/PartnerLogos/Sentry/* | Removes Sentry logo components and index |
| packages/ui-components/src/Icons/PartnerLogos/Scaleway/* | Removes Scaleway logo components and index |
| packages/ui-components/src/Icons/PartnerLogos/Rackspace/* | Removes Rackspace logo components and index |
| packages/ui-components/src/Icons/PartnerLogos/OpenSSF/* | Removes OpenSSF logo components and index |
| packages/ui-components/src/Icons/PartnerLogos/IBM/* | Removes IBM logo components and index |
| packages/ui-components/src/Icons/PartnerLogos/EquinixMetal/* | Removes EquinixMetal logo components and index |
| packages/ui-components/src/Icons/PartnerLogos/DataDog/* | Removes DataDog logo components and index |
| packages/ui-components/src/Icons/PartnerLogos/Crowdin/* | Removes Crowdin logo components and index |
| packages/ui-components/src/Icons/PartnerLogos/ARM/* | Removes ARM logo components and index |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is overreach - we partner with many of these organizations - especially through direct usage and their in-kind sponsorship.
I'd rather we cut issues for each here and determine how we want to add them to the sponsors page.
|
The problem isn’t how we want to add them, it’s that we’re not allowed to use their logos. The only logos we’re permitted to use are the ones listed here: https://openjsf.org/partners. That’s the list the foundation provided me. I’m not sure about the status of the other companies with the foundation, even though we do use their services or machines. |
|
Apologies - I assume this surfaced as part of #7991. |
|
This lowers the bundle size from ~2.6 mb to 2.33 mb! |
|
They are probably being bundled due to wildcard imports. We should treeshake them. |
|
But I do feel we should keep the logos tho. |
Description
As the title says, I don’t think we should keep logos that we’re not using. If at some point we’re allowed to use the logo because an agreement is reached, then we can obtain it again.
Validation
Related Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.