Skip to content

test-tls-check-server-identity var->const, assert, string template #9986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

test-tls-check-server-identity var->const, assert, string template #9986

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b0c4cd
test: update test-tls-check-server-identity.js
koxauvin Dec 1, 2016
a55a9ac
test: update test-tls-check-server-identity.js
koxauvin Dec 5, 2016
7b341c3
test: update test-tls-check-server-identity.js
koxauvin Dec 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions test/parallel/test-tls-check-server-identity.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
'use strict';
var common = require('../common');
var assert = require('assert');
var util = require('util');
const common = require('../common');

if (!common.hasCrypto) {
common.skip('missing crypto');
return;
}
var tls = require('tls');

const assert = require('assert');
const util = require('util');

var tests = [
const tls = require('tls');

const tests = [
// False-y values.
{
host: false,
Expand Down Expand Up @@ -253,9 +254,9 @@ var tests = [
];

tests.forEach(function(test, i) {
var err = tls.checkServerIdentity(test.host, test.cert);
assert.equal(err && err.reason,
test.error,
'Test#' + i + ' failed: ' + util.inspect(test) + '\n' +
test.error + ' != ' + (err && err.reason));
const err = tls.checkServerIdentity(test.host, test.cert);
assert.strictEqual(err && err.reason,
test.error,
`Test# ${i} failed: ${util.inspect(test)} \n` +
`${test.error} != ${(err && err.reason)}`);
});