src: refactor reading of options in contextify #8850
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
Member
Author
targos
approved these changes
Sep 29, 2016
src/node_contextify.cc
Outdated
Member
There was a problem hiding this comment.
Linter is unhappy about whitespaces here.
addaleax
approved these changes
Sep 29, 2016
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM with a green CI/linter run
cjihrig
approved these changes
Sep 30, 2016
fhinkel
force-pushed
the
FuncCallbackInfo
branch
2 times, most recently
from
c1ac941 to
958dcdd
Compare
Refactor various functions that read values from the contextify options object. Rather than passing args and the index, pass the value at that index. We use env->isolate() rather than args.GetIsolate(), but since env was constructed from args, this is the same isolate.
fhinkel
force-pushed
the
FuncCallbackInfo
branch
from
958dcdd to
242e4a2
Compare
Member
Author
fhinkel
added a commit
to fhinkel/node
that referenced
this pull request
Oct 3, 2016
Refactor various functions that read values from the contextify options object. Rather than passing args and the index, pass the value at that index. We use env->isolate() rather than args.GetIsolate(), but since env was constructed from args, this is the same isolate. PR-URL: nodejs#8850 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
Author
|
Landed in c32cfcb. |
jasnell
pushed a commit
that referenced
this pull request
Oct 6, 2016
Refactor various functions that read values from the contextify options object. Rather than passing args and the index, pass the value at that index. We use env->isolate() rather than args.GetIsolate(), but since env was constructed from args, this is the same isolate. PR-URL: #8850 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Contributor
|
@fhinkel I have set this as do not land. If you feel it should be backported please feel free to do so |
Member
Author
|
No need to backport it. Thanks! |
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
Refactor various functions that read values from the contextify options object. Rather than passing args and the index, pass the value at that index. We use env->isolate() rather than args.GetIsolate(), but since env was constructed from args, this is the same isolate. PR-URL: #8850 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX) passesAffected core subsystem(s)
src, contextify
Description of change
Refactor various functions that read values from the contextify options object.
Rather than passing
argsand the index, pass the value at that index.We use
env->isolate()rather thanargs.GetIsolate(), but sinceenvwas constructed from
args, this is the same isolate.