Skip to content

Conversation

@ChALkeR
Copy link
Member

@ChALkeR ChALkeR commented Sep 20, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

Description of change

Clean up icu/README.md formatting:

  1. Normalize headings.
  2. Specify language in all code blocks.

Extracted from #8551 to make that one easier to review.

/cc @Trott, @srl295.

@ChALkeR ChALkeR added tools Issues and PRs related to the tools directory. i18n-api Issues and PRs related to the i18n implementation. labels Sep 20, 2016
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 20, 2016
@Trott
Copy link
Member

Trott commented Sep 20, 2016

LGTM

Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

 1. Normalize headings.
 2. Specify language in all code blocks.

PR-URL: nodejs#8660
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@ChALkeR ChALkeR merged commit fe69d0d into nodejs:master Sep 20, 2016
@ChALkeR
Copy link
Member Author

ChALkeR commented Sep 20, 2016

Landed in fe69d0d.

Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
 1. Normalize headings.
 2. Specify language in all code blocks.

PR-URL: #8660
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n-api Issues and PRs related to the i18n implementation. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants