Skip to content

Conversation

@not-an-aardvark
Copy link
Contributor

🎉

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Adds me to the collaborators list!

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 13, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Sep 13, 2016

LGTM

@addaleax
Copy link
Member

LGTM! \o/

@not-an-aardvark
Copy link
Contributor Author

@evanlucas
Copy link
Contributor

yay! LGTM

@Trott
Copy link
Member

Trott commented Sep 13, 2016

LGTM

@not-an-aardvark
Copy link
Contributor Author

Landed in ead820d

not-an-aardvark added a commit that referenced this pull request Sep 13, 2016
PR-URL: #8525
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@not-an-aardvark not-an-aardvark deleted the add-self-to-readme branch September 13, 2016 22:44
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
PR-URL: #8525
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
PR-URL: #8525
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
PR-URL: #8525
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
PR-URL: #8525
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
PR-URL: #8525
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants