test: test non-buffer/string with zlib #8350
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
zlib
Check the error condition testing for passing something other than a string or buffer. Currently, there are no tests for this.
|
LGTM |
|
LGTM |
|
Perhaps this needs more tests for passing various types of data, e.g. a number? |
|
Couldn't hurt to expand the tests a bit more |
|
Added a few more types. CI again: https://ci.nodejs.org/job/node-test-pull-request/3925/ |
|
arm-fanned failure looks unrelated. LGTM. |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Sep 2, 2016
Check the error condition testing for passing something other than a string or buffer. Currently, there are no tests for this. PR-URL: nodejs#8350 Reviewed-By: Anna Henningsen <[email protected]> Reviewed By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
|
Landed in 9826a79 |
Closed
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Sep 8, 2016
Check the error condition testing for passing something other than a string or buffer. Currently, there are no tests for this. PR-URL: nodejs#8350 Reviewed-By: Anna Henningsen <[email protected]> Reviewed By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Sep 9, 2016
Check the error condition testing for passing something other than a string or buffer. Currently, there are no tests for this. PR-URL: #8350 Reviewed-By: Anna Henningsen <[email protected]> Reviewed By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 30, 2016
Check the error condition testing for passing something other than a string or buffer. Currently, there are no tests for this. PR-URL: #8350 Reviewed-By: Anna Henningsen <[email protected]> Reviewed By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2016
Check the error condition testing for passing something other than a string or buffer. Currently, there are no tests for this. PR-URL: #8350 Reviewed-By: Anna Henningsen <[email protected]> Reviewed By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
Check the error condition testing for passing something other than a string or buffer. Currently, there are no tests for this. PR-URL: #8350 Reviewed-By: Anna Henningsen <[email protected]> Reviewed By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
Check the error condition testing for passing something other than a string or buffer. Currently, there are no tests for this. PR-URL: #8350 Reviewed-By: Anna Henningsen <[email protected]> Reviewed By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test zlib
Description of change
Check the error condition testing for passing something other than a
string or buffer. Currently, there are no tests for this error condition.