Skip to content

Conversation

@andrasq
Copy link

@andrasq andrasq commented Jul 19, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 19, 2016
@Trott
Copy link
Member

Trott commented Jul 19, 2016

LGTM. We don't have a requirement that people include a surname or anything, right? Whatever they wish to be identified by is OK? Or am I mistaken about that?

@andrasq
Copy link
Author

andrasq commented Jul 19, 2016

@evanlucas
Copy link
Contributor

LGTM. Welcome aboard!

@andrasq
Copy link
Author

andrasq commented Jul 20, 2016

landed in f1d804a

andrasq pushed a commit that referenced this pull request Jul 20, 2016
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
PR-URL: #7801
@andrasq andrasq closed this Jul 20, 2016
@bnoordhuis
Copy link
Member

We don't have a requirement that people include a surname or anything, right?

Not a requirement, just a preference.

evanlucas pushed a commit that referenced this pull request Jul 21, 2016
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
PR-URL: #7801
MylesBorins pushed a commit that referenced this pull request Sep 9, 2016
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
PR-URL: #7801
MylesBorins pushed a commit that referenced this pull request Sep 28, 2016
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
PR-URL: #7801
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
PR-URL: #7801
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
PR-URL: #7801
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants