Skip to content

Conversation

@yorkie
Copy link
Contributor

@yorkie yorkie commented May 26, 2016

Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Add @yorkie to collaborators list

R= @Trott

@yorkie yorkie added the doc Issues and PRs related to the documentations. label May 26, 2016
@addaleax
Copy link
Member

LGTM!

@yorkie
Copy link
Contributor Author

yorkie commented May 26, 2016

@Trott
Copy link
Member

Trott commented May 26, 2016

LGTM

@Trott
Copy link
Member

Trott commented May 26, 2016

CI problems are unrelated. (I think we're having issues with a test not cleaning up after itself. There might already be a PR in to fix it.) I think this is OK to land.

PR-URL: nodejs#7004
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@yorkie yorkie force-pushed the add-yorkie-to-collaborators branch from a712c9d to 841c702 Compare May 26, 2016 20:23
@yorkie yorkie merged commit 841c702 into nodejs:master May 26, 2016
@yorkie
Copy link
Contributor Author

yorkie commented May 26, 2016

Landed in 841c702, thank you @addaleax and @Trott :-)

@yorkie yorkie deleted the add-yorkie-to-collaborators branch May 26, 2016 20:28
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 30, 2016
PR-URL: nodejs#7004
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
PR-URL: #7004
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
PR-URL: #7004
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
PR-URL: #7004
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
PR-URL: #7004
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7004
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7004
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants