- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33.6k
doc: add yorkie to collaborators #7004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | LGTM! | 
| LGTM | 
| CI problems are unrelated. (I think we're having issues with a test not cleaning up after itself. There might already be a PR in to fix it.) I think this is OK to land. | 
PR-URL: nodejs#7004 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
a712c9d    to
    841c702      
    Compare
  
    
    
  Fishrock123 
      pushed a commit
        to Fishrock123/node
      that referenced
      this pull request
    
      May 30, 2016 
    
    
      
  
    
      
    
  
PR-URL: nodejs#7004 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
    
  rvagg 
      pushed a commit
      that referenced
      this pull request
    
      Jun 2, 2016 
    
    
      
  
    
      
    
  
PR-URL: #7004 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
    
  MylesBorins 
      pushed a commit
      that referenced
      this pull request
    
      Jul 11, 2016 
    
    
      
  
    
      
    
  
PR-URL: #7004 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
    
  MylesBorins 
      pushed a commit
      that referenced
      this pull request
    
      Jul 12, 2016 
    
    
      
  
    
      
    
  
PR-URL: #7004 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
    
  MylesBorins 
      pushed a commit
      that referenced
      this pull request
    
      Jul 12, 2016 
    
    
      
  
    
      
    
  
PR-URL: #7004 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
      
     Merged
  
    
  MylesBorins 
      pushed a commit
      that referenced
      this pull request
    
      Jul 14, 2016 
    
    
      
  
    
      
    
  
PR-URL: #7004 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
    
  MylesBorins 
      pushed a commit
      that referenced
      this pull request
    
      Jul 14, 2016 
    
    
      
  
    
      
    
  
PR-URL: #7004 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Checklist
Affected core subsystem(s)
doc
Description of change
Add @yorkie to collaborators list
R= @Trott