Skip to content

lib: check SharedArrayBuffer existence in fast-utf8-stream #60453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

lib: check SharedArrayBuffer existence in fast-utf8-stream #60453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions lib/internal/streams/fast-utf8-stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ const {
const BUSY_WRITE_TIMEOUT = 100;
const kEmptyBuffer = Buffer.allocUnsafe(0);

const kNil = new Int32Array(new SharedArrayBuffer(4));
const haveSAB = typeof SharedArrayBuffer !== 'undefined';
const kNil = haveSAB ? new Int32Array(new SharedArrayBuffer(4)) : null;
Comment on lines +52 to +53
Copy link
Contributor

@aduh95 aduh95 Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the haveSAB variable useful?

Suggested change
const haveSAB = typeof SharedArrayBuffer !== 'undefined';
const kNil = haveSAB ? new Int32Array(new SharedArrayBuffer(4)) : null;
const kNil = SharedArrayBuffer && new Int32Array(new SharedArrayBuffer(4));

Copy link
Member Author

@codebytere codebytere Oct 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aduh95 we need it below to choose sleep implementation, no?

Copy link
Contributor

@aduh95 aduh95 Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use kNil for that

Copy link
Member

@targos targos Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggested code would throw an error if SharedArrayBuffer is not defined.

Copy link
Contributor

@aduh95 aduh95 Oct 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is declared above, it wouldn't throw even if undefined:

node/lib/internal/streams/fast-utf8-stream.js

Line 15 in 6547f21

SharedArrayBuffer,


function sleep(ms) {
// Also filters out NaN, non-number types, including empty strings, but allows bigints
Expand All @@ -61,8 +62,12 @@ function sleep(ms) {
throw new ERR_INVALID_ARG_VALUE.RangeError('ms', ms,
'must be a number greater than 0 and less than Infinity');
}

AtomicsWait(kNil, 0, 0, Number(ms));
if (haveSAB) {
AtomicsWait(kNil, 0, 0, Number(ms));
} else {
const { sleep: _sleep } = internalBinding('util');
_sleep(ms);
}
}

// 16 KB. Don't write more than docker buffer size.
Expand Down
Loading