-
-
Couldn't load subscription status.
- Fork 33.6k
tls: fix leak on invalid protocol method #60427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
codebytere
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
codebytere:one-more-leak
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60427 +/- ##
==========================================
- Coverage 88.59% 88.58% -0.01%
==========================================
Files 704 704
Lines 207774 207826 +52
Branches 40035 40042 +7
==========================================
+ Hits 184068 184110 +42
- Misses 15748 15754 +6
- Partials 7958 7962 +4
🚀 New features to boost your workflow:
|
57b5b01 to
44ff469
Compare
addaleax
reviewed
Oct 28, 2025
44ff469 to
c1970ef
Compare
c1970ef to
c84fed3
Compare
addaleax
approved these changes
Oct 28, 2025
mertcanaltin
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
crypto
Issues and PRs related to the crypto subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately looks like this can happen with an invalid
secureProtocolas well - if validation fails inSecureContext::Init,Resetwould be called via dtor butctx_would still be nullptr soenv()->external_memory_accounter()->Decreasewouldn't be called, leading to the same stacktrace as #60390.Please let me know if there's a better fix here.