lib: use validators for argument validation #59416
Merged
+39
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
child_process
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59416 +/- ##
==========================================
- Coverage 89.89% 89.88% -0.01%
==========================================
Files 656 656
Lines 192983 192981 -2
Branches 37849 37849
==========================================
- Hits 173478 173466 -12
- Misses 12055 12064 +9
- Partials 7450 7451 +1
🚀 New features to boost your workflow:
|
BridgeAR
reviewed
Aug 11, 2025
There was a problem hiding this comment.
I agree that this seems right. This is a major change though.
@meteorqz6 can you please have a look at the tests? They need to be adjusted.
BridgeAR
added
the
semver-major
meteorqz6
force-pushed
the
refactor/lib
branch
from
7ba0f1f to
2c94e58
Compare
This refactors internal validation helpers in `child_process` to use the common validators in `lib/internal/validators.js` where possible. This improves code consistency and maintainability.
meteorqz6
force-pushed
the
refactor/lib
branch
from
2c94e58 to
49c5ea1
Compare
|
I've adjusted the tests. |
|
Please take a look when you have a moment. @BridgeAR |
jasnell
approved these changes
Sep 13, 2025
daeyeon
approved these changes
Sep 14, 2025
|
@nodejs/tsc semver-major requires at least 2 TSC approvals to land. |
daeyeon
added
author ready
aduh95
approved these changes
Sep 14, 2025
anonrig
approved these changes
Sep 20, 2025
daeyeon
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 39d7303 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors internal validation helpers in
child_processto use the common validators inlib/internal/validators.jswhere possible.This improves code consistency and maintainability.