module: ensures require(esm) errors are preserved on subsequent import(esm)
#58956
+83
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds testing to make ensure top level errors thrown during ESM module import/evaluation get preserved on subsequent attempts to load the same module again no matter if require(esm) or import(esm) Refs: nodejs#58945
nodejs-github-bot
added
esm
Author
|
closed in favor of #58957 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing an ESM module with a top level error through
require(esm)leaves the ESM load cache in a somewhat broken state, causing future import(esm) calls fail silently and not propagate the original error. For more context please see #58945