test: move http proxy tests to test/client-proxy #58950
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
joyeecheung
commented
Jul 3, 2025
| const child = spawn(...args); | ||
| child.stderr.setEncoding('utf8'); | ||
| child.stderr.on('data', (data) => { | ||
| console.error('[STDERR]', data); |
Member
Author
There was a problem hiding this comment.
These logs are added for debugging, similar to what the test/common/inspector-helper.js does, otherwise the tests can be difficult to debug when they fail with no output from the child and I found myself constantly adding these logs. Would be good to have them if they ever fail/flake in the CI, otherwise it'd be a pain to add them back and forth.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58950 +/- ##
==========================================
+ Coverage 90.06% 90.09% +0.03%
==========================================
Files 645 645
Lines 189130 189130
Branches 37094 37098 +4
==========================================
+ Hits 170339 170405 +66
+ Misses 11511 11461 -50
+ Partials 7280 7264 -16 🚀 New features to boost your workflow:
|
2 tasks
github-actions
bot
removed
the
request-ci
Collaborator
joyeecheung
force-pushed
the
case-precedence
branch
from
b282d6a to
eacc14e
Compare
Collaborator
Collaborator
Rewrite to ESM to use TLA. Also add a test to make sure case precedence is honored. Refs: https://about.gitlab.com/blog/we-need-to-talk-no-proxy
joyeecheung
force-pushed
the
case-precedence
branch
from
1181314 to
ff6ba64
Compare
Member
Author
|
Superseded by #58980 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move them to a separate directory for the ease of running them. And Rewrite to ESM to use TLA.
Also add a test to make sure case precedence is honored.
Refs: https://about.gitlab.com/blog/we-need-to-talk-no-proxy
Split off from the WIP that supports http/https.request
Refs: #57872