docs: Add note that process.send and child.send use JSON.stringify() #5723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly call out that the send method on both process and child uses JSON.stringify to serialize the message Fixes nodejs#5453
Fishrock123
added
child_process
Member
|
LGTM |
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Mar 15, 2016
process.send and child.send use JSON.stringify to serialize the message. Fixes: #5453 PR-URL: #5723 Reviewed-By: Jeremy Whitlock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
|
Landed in 99a5d07 @mithun-daa ... thank you for the PR! I did update the commit message a bit to conform to our commit guidelines. |
evanlucas
pushed a commit
that referenced
this pull request
Mar 15, 2016
process.send and child.send use JSON.stringify to serialize the message. Fixes: #5453 PR-URL: #5723 Reviewed-By: Jeremy Whitlock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
rvagg
pushed a commit
that referenced
this pull request
Mar 16, 2016
process.send and child.send use JSON.stringify to serialize the message. Fixes: #5453 PR-URL: #5723 Reviewed-By: Jeremy Whitlock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 17, 2016
process.send and child.send use JSON.stringify to serialize the message. Fixes: #5453 PR-URL: #5723 Reviewed-By: Jeremy Whitlock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
added
land-on-v4.x
and removed
doc
MylesBorins
added
doc
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
process.send and child.send use JSON.stringify to serialize the message. Fixes: #5453 PR-URL: #5723 Reviewed-By: Jeremy Whitlock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
process.send and child.send use JSON.stringify to serialize the message. Fixes: #5453 PR-URL: #5723 Reviewed-By: Jeremy Whitlock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Affected core subsystem(s)
Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)
docs
Description of change
Please provide a description of the change here.
Explicitly call out that the send method on both process and child uses JSON.stringify to serialize the message
Fixes #5453