-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
child_process: fix parsing messages with splitted length field #56106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 6 commits into
nodejs:main
from
MGorkov:fix/child_process_advanced
Jan 18, 2025
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a9bb53a
child_process: fix parsing messages with splitted length field
MGorkov 065942d
child_process: add test for issue 55834
MGorkov d9379af
Update test/parallel/test-child-process-advanced-serialization-splitt…
MGorkov 0a89f5e
Update lib/internal/child_process/serialization.js
MGorkov a7ef03a
Update lib/internal/child_process/serialization.js
MGorkov 73a8e0d
child_process: fix linter error for issue 55834
MGorkov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
test/parallel/test-child-process-advanced-serialization-splitted-length-field.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| 'use strict'; | ||
| const common = require('../common'); | ||
| const child_process = require('child_process'); | ||
|
|
||
| // Regression test for https://github.com/nodejs/node/issues/55834 | ||
| const msgLen = 65521; | ||
| let cnt = 10; | ||
|
|
||
| if (process.argv[2] === 'child') { | ||
| const msg = Buffer.allocUnsafe(msgLen); | ||
| (function send() { | ||
| if (cnt--) { | ||
| process.send(msg, send); | ||
| } else { | ||
| process.nextTick(() => { | ||
| process.exit(0); | ||
| }); | ||
| } | ||
| })() | ||
|
Check failure on line 19 in test/parallel/test-child-process-advanced-serialization-splitted-length-field.js
|
||
MGorkov marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } else { | ||
| const child = child_process.spawn(process.execPath, [__filename, 'child'], { | ||
| stdio: ['inherit', 'inherit', 'inherit', 'ipc'], | ||
| serialization: 'advanced' | ||
| }); | ||
| child.on('message', common.mustCall(cnt)); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.