Skip to content

build: fix GN build for sqlite and nghttp2 #55529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2024
Merged

build: fix GN build for sqlite and nghttp2 #55529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions deps/nghttp2/unofficial.gni
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ template("nghttp2_gn_build") {
if (is_clang || !is_win) {
cflags_c = [
"-Wno-implicit-fallthrough",
# Ref https://github.com/nghttp2/nghttp2/pull/2258
# This can be removed when the above PR is ingested.
"-Wno-extra-semi",
]
}
}
Expand Down
8 changes: 7 additions & 1 deletion deps/sqlite/unofficial.gni
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,14 @@ template("sqlite_gn_build") {
forward_variables_from(invoker, "*")
public_configs = [ ":sqlite_config" ]
sources = gypi_values.sqlite_sources
cflags_c = [
"-Wno-implicit-fallthrough",
"-Wno-unreachable-code-return",
"-Wno-unreachable-code-break",
"-Wno-unreachable-code",
]
if (is_win) {
cflags_c = [
cflags_c += [
"-Wno-sign-compare",
"-Wno-unused-but-set-variable",
"-Wno-unused-function",
Expand Down
Loading