-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
src,lib: add performance.uvMetricsInfo #54413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
95d36a3
1861bb2
85dbd8f
aa4dc99
c1385ed
856d4ae
13fe044
391ce64
0e9cf0e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -261,6 +261,30 @@ void LoopIdleTime(const FunctionCallbackInfo<Value>& args) { | |
| args.GetReturnValue().Set(1.0 * idle_time / NANOS_PER_MILLIS); | ||
| } | ||
|
|
||
| void UvMetricsInfo(const FunctionCallbackInfo<Value>& args) { | ||
| Environment* env = Environment::GetCurrent(args); | ||
| uv_metrics_t metrics; | ||
|
|
||
| // uv_metrics_info always return 0 | ||
| uv_metrics_info(env->event_loop(), &metrics); | ||
RafaelGSS marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| Local<Object> obj = Object::New(env->isolate()); | ||
| obj->Set(env->context(), | ||
| env->loop_count(), | ||
| Integer::NewFromUnsigned(env->isolate(), metrics.loop_count)) | ||
| .Check(); | ||
| obj->Set(env->context(), | ||
| env->events(), | ||
| Integer::NewFromUnsigned(env->isolate(), metrics.events)) | ||
| .Check(); | ||
| obj->Set(env->context(), | ||
| env->events_waiting(), | ||
| Integer::NewFromUnsigned(env->isolate(), metrics.events_waiting)) | ||
| .Check(); | ||
|
Comment on lines
+271
to
+283
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just a note for the future optimization: maybe we should use a buffer to store these values to avoid creating and returning js objects from c++.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, I have plans to return a typed array and build the object in JS land. I'll do it in a follow up PR. |
||
|
|
||
| args.GetReturnValue().Set(obj); | ||
| } | ||
|
|
||
| void CreateELDHistogram(const FunctionCallbackInfo<Value>& args) { | ||
| Environment* env = Environment::GetCurrent(args); | ||
| int64_t interval = args[0].As<Integer>()->Value(); | ||
|
|
@@ -324,6 +348,7 @@ static void CreatePerIsolateProperties(IsolateData* isolate_data, | |
| SetMethod(isolate, target, "loopIdleTime", LoopIdleTime); | ||
| SetMethod(isolate, target, "createELDHistogram", CreateELDHistogram); | ||
| SetMethod(isolate, target, "markBootstrapComplete", MarkBootstrapComplete); | ||
| SetMethod(isolate, target, "uvMetricsInfo", UvMetricsInfo); | ||
| SetFastMethodNoSideEffect( | ||
| isolate, target, "now", SlowPerformanceNow, &fast_performance_now); | ||
| } | ||
|
|
@@ -390,6 +415,7 @@ void RegisterExternalReferences(ExternalReferenceRegistry* registry) { | |
| registry->Register(LoopIdleTime); | ||
| registry->Register(CreateELDHistogram); | ||
| registry->Register(MarkBootstrapComplete); | ||
| registry->Register(UvMetricsInfo); | ||
| registry->Register(SlowPerformanceNow); | ||
| registry->Register(FastPerformanceNow); | ||
| registry->Register(fast_performance_now.GetTypeInfo()); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| 'use strict'; | ||
|
|
||
| require('../common'); | ||
|
|
||
| const fixtures = require('../common/fixtures'); | ||
|
|
||
| const filepath = fixtures.path('x.txt'); | ||
|
|
||
| const assert = require('node:assert'); | ||
| const fs = require('node:fs'); | ||
| const { performance } = require('node:perf_hooks'); | ||
|
|
||
| const { nodeTiming } = performance; | ||
|
|
||
| function safeMetricsInfo(cb) { | ||
| setImmediate(() => { | ||
| const info = nodeTiming.uvMetricsInfo; | ||
| cb(info); | ||
| }); | ||
| } | ||
|
|
||
| { | ||
| const info = nodeTiming.uvMetricsInfo; | ||
| assert.strictEqual(info.loopCount, 0); | ||
| assert.strictEqual(info.events, 0); | ||
| // This is the only part of the test that we test events waiting | ||
| // Adding checks for this property will make the test flaky | ||
| // as it can be highly influenced by race conditions. | ||
| assert.strictEqual(info.eventsWaiting, 0); | ||
| } | ||
|
|
||
| { | ||
| // The synchronous call should obviously not affect the uv metrics | ||
| const fd = fs.openSync(filepath, 'r'); | ||
| fs.readFileSync(fd); | ||
| const info = nodeTiming.uvMetricsInfo; | ||
| assert.strictEqual(info.loopCount, 0); | ||
| assert.strictEqual(info.events, 0); | ||
| assert.strictEqual(info.eventsWaiting, 0); | ||
| } | ||
|
|
||
| { | ||
| function openFile(info) { | ||
| assert.strictEqual(info.loopCount, 1); | ||
| // 1. ? event | ||
| assert.strictEqual(info.events, 1); | ||
|
|
||
| fs.open(filepath, 'r', (err) => { | ||
| assert.ifError(err); | ||
| safeMetricsInfo(afterOpenFile); | ||
| }); | ||
| } | ||
|
|
||
| function afterOpenFile(info) { | ||
| assert.strictEqual(info.loopCount, 2); | ||
| // 1. ? event | ||
| // 2. uv_fs_open | ||
| assert.strictEqual(info.events, 2); | ||
|
|
||
| fs.readFile(filepath, (err) => { | ||
| assert.ifError(err); | ||
| safeMetricsInfo(afterReadFile); | ||
| }); | ||
| } | ||
|
|
||
| function afterReadFile(info) { | ||
| assert.strictEqual(info.loopCount, 6); | ||
| // 1. ? event | ||
| assert.strictEqual(info.events, 6); | ||
| // 1. ? | ||
| } | ||
|
|
||
| safeMetricsInfo(openFile); | ||
| } |
Uh oh!
There was an error while loading. Please reload this page.