Skip to content

deps: update V8 to 12.3 #52293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

deps: update V8 to 12.3 #52293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1c39b52
deps: update V8 to 12.3.219.16
targos Apr 18, 2024
6a99f79
build: reset embedder string to "-node.0"
targos Apr 18, 2024
9b1dc2d
src: update NODE_MODULE_VERSION to 126
targos Apr 8, 2024
557968a
deps: always define V8_EXPORT_PRIVATE as no-op
targos Sep 21, 2022
99a9304
deps: silence irrelevant V8 warning
targos Jun 21, 2022
f059525
deps: disable V8 concurrent sparkplug compilation
targos Apr 6, 2023
ab11bf5
deps: avoid compilation error with ASan
targos Jul 31, 2023
79a7aac
deps: remove usage of a C++20 feature from V8
targos Aug 10, 2023
33c3b60
deps: patch V8 to avoid duplicated zlib symbol
targos Sep 16, 2023
8c7b0f6
deps: patch V8 to support compilation with MSVC
StefanStojanovic Apr 16, 2024
bb9959b
deps: silence internal V8 deprecation warning
targos Mar 11, 2024
3fb52db
deps: V8: backport c4be0a97f981
richardlau Mar 21, 2024
569425c
deps: V8: cherry-pick cd10ad7cdbe5
joyeecheung Apr 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
12 changes: 7 additions & 5 deletions deps/v8/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,10 @@
/test/wasm-spec-tests/tests.tar.gz
/third_party/*
!/third_party/antlr4
!/third_party/cpu_features
/third_party/cpu_features/src
!/third_party/inspector_protocol
!/third_party/jsoncpp
/third_party/jsoncpp/source
!/third_party/colorama
/third_party/colorama/src
!/third_party/cpu_features
/third_party/cpu_features/src
!/third_party/glibc
!/third_party/googletest
/third_party/googletest/src/*
Expand All @@ -80,6 +77,11 @@
!/third_party/googletest/src/googletest/include/gtest
/third_party/googletest/src/googletest/include/gtest/*
!/third_party/googletest/src/googletest/include/gtest/gtest_prod.h
!/third_party/inspector_protocol
!/third_party/jsoncpp
/third_party/jsoncpp/source
!/third_party/re2
/third_party/re2/src
!/third_party/test262-harness
!/third_party/v8
!/third_party/wasm-api
Expand Down
1 change: 1 addition & 0 deletions deps/v8/AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,3 +311,4 @@ Zhongping Wang <[email protected]>
Yang Xiang <[email protected]>
Kotaro Ohsugi <[email protected]>
Jing Peiyang <[email protected]>
magic-akari <[email protected]>
17 changes: 11 additions & 6 deletions deps/v8/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1689,6 +1689,8 @@ filegroup(
"src/heap/memory-balancer.h",
"src/heap/memory-chunk.cc",
"src/heap/memory-chunk.h",
"src/heap/memory-chunk-header.cc",
"src/heap/memory-chunk-header.h",
"src/heap/memory-chunk-inl.h",
"src/heap/memory-chunk-layout.cc",
"src/heap/memory-chunk-layout.h",
Expand Down Expand Up @@ -2792,6 +2794,7 @@ filegroup(
"src/wasm/code-space-access.cc",
"src/wasm/code-space-access.h",
"src/wasm/compilation-environment.h",
"src/wasm/compilation-environment-inl.h",
"src/wasm/constant-expression.cc",
"src/wasm/constant-expression.h",
"src/wasm/constant-expression-interface.cc",
Expand Down Expand Up @@ -2883,6 +2886,7 @@ filegroup(
"src/wasm/wasm-value.h",
"src/wasm/well-known-imports.cc",
"src/wasm/well-known-imports.h",
"src/wasm/wrappers.cc",
],
"//conditions:default": [],
}),
Expand Down Expand Up @@ -3011,6 +3015,8 @@ filegroup(
"src/compiler/compiler-source-position-table.h",
"src/compiler/constant-folding-reducer.cc",
"src/compiler/constant-folding-reducer.h",
"src/compiler/const-tracking-let-helpers.cc",
"src/compiler/const-tracking-let-helpers.h",
"src/compiler/control-equivalence.cc",
"src/compiler/control-equivalence.h",
"src/compiler/control-flow-optimizer.cc",
Expand Down Expand Up @@ -3185,7 +3191,7 @@ filegroup(
"src/compiler/turboshaft/builtin-call-descriptors.h",
"src/compiler/turboshaft/csa-optimize-phase.cc",
"src/compiler/turboshaft/csa-optimize-phase.h",
"src/compiler/turboshaft/dataview-reducer.h",
"src/compiler/turboshaft/dataview-lowering-reducer.h",
"src/compiler/turboshaft/code-elimination-and-simplification-phase.cc",
"src/compiler/turboshaft/code-elimination-and-simplification-phase.h",
"src/compiler/turboshaft/dead-code-elimination-reducer.h",
Expand All @@ -3199,7 +3205,7 @@ filegroup(
"src/compiler/turboshaft/define-assembler-macros.inc",
"src/compiler/turboshaft/deopt-data.h",
"src/compiler/turboshaft/explicit-truncation-reducer.h",
"src/compiler/turboshaft/fast-api-call-reducer.h",
"src/compiler/turboshaft/fast-api-call-lowering-reducer.h",
"src/compiler/turboshaft/fast-hash.h",
"src/compiler/turboshaft/graph.cc",
"src/compiler/turboshaft/graph.h",
Expand Down Expand Up @@ -3249,7 +3255,6 @@ filegroup(
"src/compiler/turboshaft/recreate-schedule.h",
"src/compiler/turboshaft/recreate-schedule-phase.cc",
"src/compiler/turboshaft/recreate-schedule-phase.h",
"src/compiler/turboshaft/reduce-args-helper.h",
"src/compiler/turboshaft/reducer-traits.h",
"src/compiler/turboshaft/representations.cc",
"src/compiler/turboshaft/representations.h",
Expand All @@ -3265,7 +3270,7 @@ filegroup(
"src/compiler/turboshaft/simplify-tf-loops.h",
"src/compiler/turboshaft/snapshot-table.h",
"src/compiler/turboshaft/snapshot-table-opindex.h",
"src/compiler/turboshaft/stack-check-reducer.h",
"src/compiler/turboshaft/stack-check-lowering-reducer.h",
"src/compiler/turboshaft/store-store-elimination-phase.cc",
"src/compiler/turboshaft/store-store-elimination-phase.h",
"src/compiler/turboshaft/store-store-elimination-reducer.h",
Expand Down Expand Up @@ -3374,8 +3379,8 @@ filegroup(
"src/compiler/turboshaft/wasm-assembler-helpers.h",
"src/compiler/turboshaft/wasm-gc-optimize-phase.cc",
"src/compiler/turboshaft/wasm-gc-optimize-phase.h",
"src/compiler/turboshaft/wasm-gc-type-reducer.cc",
"src/compiler/turboshaft/wasm-gc-type-reducer.h",
"src/compiler/turboshaft/wasm-gc-typed-optimization-reducer.cc",
"src/compiler/turboshaft/wasm-gc-typed-optimization-reducer.h",
"src/compiler/turboshaft/wasm-load-elimination-reducer.h",
"src/compiler/turboshaft/wasm-lowering-phase.cc",
"src/compiler/turboshaft/wasm-lowering-phase.h",
Expand Down
54 changes: 41 additions & 13 deletions deps/v8/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1149,6 +1149,9 @@ config("features") {
if (v8_fuzzilli) {
defines += [ "V8_FUZZILLI" ]
}
if (v8_enable_fuzztest) {
defines += [ "V8_ENABLE_FUZZTEST" ]
}
if (v8_enable_short_builtin_calls) {
defines += [ "V8_SHORT_BUILTIN_CALLS" ]
}
Expand Down Expand Up @@ -1482,7 +1485,6 @@ config("toolchain") {

if (is_clang) {
cflags += [
"-Wmissing-field-initializers",
"-Wunreachable-code",

# TODO(v8:12245): Fix shadowing instances and remove.
Expand All @@ -1496,11 +1498,6 @@ config("toolchain") {
# warning.
cflags += [ "-Wctad-maybe-unsupported" ]
}

if (v8_current_cpu == "x64" || v8_current_cpu == "arm64" ||
v8_current_cpu == "mips64el" || v8_current_cpu == "riscv64") {
cflags += [ "-Wshorten-64-to-32" ]
}
}

if (is_clang || !is_win) {
Expand Down Expand Up @@ -1723,6 +1720,17 @@ config("toolchain") {
}
}

config("strict_warnings") {
cflags = []
if (is_clang) {
if (v8_current_cpu == "x64" || v8_current_cpu == "arm64" ||
v8_current_cpu == "mips64el" || v8_current_cpu == "riscv64") {
cflags += [ "-Wshorten-64-to-32" ]
}
cflags += [ "-Wmissing-field-initializers" ]
}
}

# For code that is hot during mksnapshot. In fast-mksnapshot builds, we
# optimize some files even in debug builds to speed up mksnapshot times.
config("always_turbofanimize") {
Expand Down Expand Up @@ -3304,6 +3312,7 @@ v8_header_set("v8_internal_headers") {
"src/compiler/common-operator.h",
"src/compiler/compilation-dependencies.h",
"src/compiler/compiler-source-position-table.h",
"src/compiler/const-tracking-let-helpers.h",
"src/compiler/constant-folding-reducer.h",
"src/compiler/control-equivalence.h",
"src/compiler/control-flow-optimizer.h",
Expand Down Expand Up @@ -3401,7 +3410,7 @@ v8_header_set("v8_internal_headers") {
"src/compiler/turboshaft/code-elimination-and-simplification-phase.h",
"src/compiler/turboshaft/copying-phase.h",
"src/compiler/turboshaft/csa-optimize-phase.h",
"src/compiler/turboshaft/dataview-reducer.h",
"src/compiler/turboshaft/dataview-lowering-reducer.h",
"src/compiler/turboshaft/dead-code-elimination-reducer.h",
"src/compiler/turboshaft/debug-feature-lowering-phase.h",
"src/compiler/turboshaft/debug-feature-lowering-reducer.h",
Expand All @@ -3411,7 +3420,7 @@ v8_header_set("v8_internal_headers") {
"src/compiler/turboshaft/deopt-data.h",
"src/compiler/turboshaft/duplication-optimization-reducer.h",
"src/compiler/turboshaft/explicit-truncation-reducer.h",
"src/compiler/turboshaft/fast-api-call-reducer.h",
"src/compiler/turboshaft/fast-api-call-lowering-reducer.h",
"src/compiler/turboshaft/fast-hash.h",
"src/compiler/turboshaft/graph-builder.h",
"src/compiler/turboshaft/graph-visualizer.h",
Expand Down Expand Up @@ -3440,7 +3449,6 @@ v8_header_set("v8_internal_headers") {
"src/compiler/turboshaft/pretenuring-propagation-reducer.h",
"src/compiler/turboshaft/recreate-schedule-phase.h",
"src/compiler/turboshaft/recreate-schedule.h",
"src/compiler/turboshaft/reduce-args-helper.h",
"src/compiler/turboshaft/reducer-traits.h",
"src/compiler/turboshaft/representations.h",
"src/compiler/turboshaft/required-optimization-reducer.h",
Expand All @@ -3452,7 +3460,7 @@ v8_header_set("v8_internal_headers") {
"src/compiler/turboshaft/simplify-tf-loops.h",
"src/compiler/turboshaft/snapshot-table-opindex.h",
"src/compiler/turboshaft/snapshot-table.h",
"src/compiler/turboshaft/stack-check-reducer.h",
"src/compiler/turboshaft/stack-check-lowering-reducer.h",
"src/compiler/turboshaft/store-store-elimination-phase.h",
"src/compiler/turboshaft/store-store-elimination-reducer.h",
"src/compiler/turboshaft/structural-optimization-reducer.h",
Expand Down Expand Up @@ -3640,6 +3648,7 @@ v8_header_set("v8_internal_headers") {
"src/heap/marking.h",
"src/heap/memory-allocator.h",
"src/heap/memory-balancer.h",
"src/heap/memory-chunk-header.h",
"src/heap/memory-chunk-inl.h",
"src/heap/memory-chunk-layout.h",
"src/heap/memory-chunk.h",
Expand Down Expand Up @@ -4136,6 +4145,12 @@ v8_header_set("v8_internal_headers") {

if (v8_use_perfetto) {
sources -= [ "//base/trace_event/common/trace_event_common.h" ]
sources += [
"src/tracing/code-data-source.h",
"src/tracing/code-trace-context.h",
"src/tracing/perfetto-logger.h",
"src/tracing/perfetto-utils.h",
]
}

if (v8_enable_sparkplug) {
Expand Down Expand Up @@ -4195,7 +4210,7 @@ v8_header_set("v8_internal_headers") {
"src/compiler/turboshaft/int64-lowering-reducer.h",
"src/compiler/turboshaft/wasm-assembler-helpers.h",
"src/compiler/turboshaft/wasm-gc-optimize-phase.h",
"src/compiler/turboshaft/wasm-gc-type-reducer.h",
"src/compiler/turboshaft/wasm-gc-typed-optimization-reducer.h",
"src/compiler/turboshaft/wasm-js-lowering-reducer.h",
"src/compiler/turboshaft/wasm-load-elimination-reducer.h",
"src/compiler/turboshaft/wasm-lowering-phase.h",
Expand Down Expand Up @@ -4230,6 +4245,7 @@ v8_header_set("v8_internal_headers") {
"src/wasm/baseline/parallel-move.h",
"src/wasm/canonical-types.h",
"src/wasm/code-space-access.h",
"src/wasm/compilation-environment-inl.h",
"src/wasm/compilation-environment.h",
"src/wasm/constant-expression-interface.h",
"src/wasm/constant-expression.h",
Expand Down Expand Up @@ -4759,6 +4775,7 @@ v8_compiler_sources = [
"src/compiler/common-operator.cc",
"src/compiler/compilation-dependencies.cc",
"src/compiler/compiler-source-position-table.cc",
"src/compiler/const-tracking-let-helpers.cc",
"src/compiler/constant-folding-reducer.cc",
"src/compiler/control-equivalence.cc",
"src/compiler/control-flow-optimizer.cc",
Expand Down Expand Up @@ -4935,7 +4952,7 @@ if (v8_enable_webassembly) {
"src/compiler/int64-lowering.cc",
"src/compiler/turboshaft/int64-lowering-phase.cc",
"src/compiler/turboshaft/wasm-gc-optimize-phase.cc",
"src/compiler/turboshaft/wasm-gc-type-reducer.cc",
"src/compiler/turboshaft/wasm-gc-typed-optimization-reducer.cc",
"src/compiler/turboshaft/wasm-lowering-phase.cc",
"src/compiler/turboshaft/wasm-optimize-phase.cc",
"src/compiler/turboshaft/wasm-turboshaft-compiler.cc",
Expand Down Expand Up @@ -5330,6 +5347,7 @@ v8_source_set("v8_base_without_compiler") {
"src/heap/marking.cc",
"src/heap/memory-allocator.cc",
"src/heap/memory-balancer.cc",
"src/heap/memory-chunk-header.cc",
"src/heap/memory-chunk-layout.cc",
"src/heap/memory-chunk.cc",
"src/heap/memory-measurement.cc",
Expand Down Expand Up @@ -5651,6 +5669,14 @@ v8_source_set("v8_base_without_compiler") {
}
}

if (v8_use_perfetto) {
sources += [
"src/tracing/code-data-source.cc",
"src/tracing/perfetto-logger.cc",
"src/tracing/perfetto-utils.cc",
]
}

if (v8_enable_webassembly) {
sources += [
### gcmole(all) ###
Expand Down Expand Up @@ -5706,6 +5732,7 @@ v8_source_set("v8_base_without_compiler") {
"src/wasm/wasm-serialization.cc",
"src/wasm/wasm-subtyping.cc",
"src/wasm/well-known-imports.cc",
"src/wasm/wrappers.cc",
]
}

Expand Down Expand Up @@ -8131,14 +8158,15 @@ if (!build_with_chromium && v8_use_perfetto) {
"//third_party/perfetto/src/tracing/core",

# TODO(skyostil): Support non-POSIX platforms.
"//third_party/perfetto/protos/perfetto/config:cpp",
"//third_party/perfetto/protos/perfetto/trace/track_event:zero",
"//third_party/perfetto/src/tracing:in_process_backend",
"//third_party/perfetto/src/tracing:platform_impl",
]

public_deps = [
"//third_party/perfetto/include/perfetto/trace_processor",
"//third_party/perfetto/protos/perfetto/config:cpp",
"//third_party/perfetto/protos/perfetto/trace/chrome:zero",
"//third_party/perfetto/src/trace_processor:export_json",
"//third_party/perfetto/src/tracing:client_api",
]
Expand Down
Loading