-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
doc: fix links order in Buffer doc #5076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sort links in lexical order
| instance, while `ArrayBuffer#slice()` creates a copy of the slice, | ||
| the implementation of [`Buffer#slice()`][] creates a view over the existing | ||
| Buffer without copying, making `Buffer#slice()` far more efficient. | ||
| the implementation of [`Buffer#slice()`][`buf.slice()`] creates a view over the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the reference also has backticks? :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, since it points to buf.slice() reference. I could do something like [buf-slice] and use it in both cases. But this way I guess I saved some characters ))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough
|
LGTM cc @nodejs/documentation |
|
LGTM |
1 similar comment
|
LGTM |
|
LGTM |
Sort links in lexical order PR-URL: #5076 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in c714b2e |
Sort links in lexical order PR-URL: #5076 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sort links in lexical order PR-URL: #5076 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
@estliberitas you should probably join the documentation group incase you are not aware of it. |
|
@stevemao Em, I'm not aware of this. It's not up to me as far as I recall |
Sort links in lexical order PR-URL: #5076 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sort links in lexical order PR-URL: #5076 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sort links in lexical order PR-URL: #5076 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sort links in lexical order PR-URL: nodejs#5076 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sort links in lexical order