Skip to content

Conversation

@mscdex
Copy link
Contributor

@mscdex mscdex commented Jan 31, 2016

Some property names were unnecessarily quoted and there were also unnecessary spaces throughout.

@mscdex mscdex added url Issues and PRs related to the legacy built-in url module. test Issues and PRs related to the tests. labels Jan 31, 2016
@mscdex
Copy link
Contributor Author

mscdex commented Jan 31, 2016

@mscdex
Copy link
Contributor Author

mscdex commented Jan 31, 2016

CI is green except for one infrastructure-related CI failure.

@Trott
Copy link
Member

Trott commented Jan 31, 2016

LGTM

2 similar comments
@JungMinu
Copy link
Member

JungMinu commented Feb 1, 2016

LGTM

@jasnell
Copy link
Member

jasnell commented Feb 1, 2016

LGTM

jasnell pushed a commit that referenced this pull request Feb 1, 2016
PR-URL: #5014
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Feb 1, 2016

Landed in 1684957

@jasnell
Copy link
Member

jasnell commented Feb 1, 2016

lts-watch label applied :-)

@mscdex mscdex deleted the test-url-consistent-style branch February 7, 2016 19:04
rvagg pushed a commit that referenced this pull request Feb 8, 2016
PR-URL: #5014
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
PR-URL: #5014
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
PR-URL: #5014
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 18, 2016
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
PR-URL: #5014
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
PR-URL: nodejs#5014
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests. url Issues and PRs related to the legacy built-in url module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants