Skip to content

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Nov 4, 2022

man ls documentation states that:

   Exit status:
       0      if OK,

       1      if minor problems (e.g., cannot access subdirectory),

       2      if serious trouble (e.g., cannot access command-line
              argument).

Fixes #45318

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 4, 2022
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2022
@nodejs-github-bot
Copy link
Collaborator

@mscdex
Copy link
Contributor

mscdex commented Nov 4, 2022

This doesn't seem right. AFAICT 1 should be the correct exit code when no arguments are passed to npm as it should display usage in that case.

@anonrig
Copy link
Member Author

anonrig commented Nov 4, 2022

OK the issue is resolved after merging #45315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test: test/parallel/test-release-npm.js
3 participants